nptscot / npt

Data processing code, also use this repo for issue tracking for the Network Planning Tool. See https://nptscot.github.io for development version
https://www.npt.scot/
GNU Affero General Public License v3.0
5 stars 0 forks source link

Integrate CN and changing outputfolder #462

Closed wangzhao0217 closed 1 month ago

wangzhao0217 commented 1 month ago
Robinlovelace commented 1 month ago

Heads-up @wangzhao0217 I got this error:

Error: Cannot open "outputdata/2024-05-30/glasgow_and_strathclyde/combined_network_tile.geojson"; The file doesn't seem to exist.
Robinlovelace commented 1 month ago

This is the cause I think: https://github.com/nptscot/corenet/blob/main/R/corenet.R#L60

wangzhao0217 commented 1 month ago

This is the cause I think: https://github.com/nptscot/corenet/blob/main/R/corenet.R#L60

image I am using oproad_gb.gpkg, which should be the same, right? @Robinlovelace

Robinlovelace commented 1 month ago

I am using oproad_gb.gpkg, which should be the same, right? @Robinlovelace

Yes but where is it located @wangzhao0217 ?

Robinlovelace commented 1 month ago

Suggestion: create files like

"inputdata/OS_Scotland_Network_glasgow_and_strathclyde.geojson"

But with gpkg extension and upload them as a release to inputdata.

Robinlovelace commented 1 month ago

https://github.com/nptscot/inputdata/releases/tag/OS_network

Robinlovelace commented 1 month ago

Heads-up it's failing with

Error in `x[i, , drop = drop]`:
! Can't subset rows with `i`.
✖ Logical subscript `i` must be size 1 or 29749, not 0.
Run `rlang::last_trace()` to see where the error occurred.
Warning messages:
1: st_centroid assumes attributes are constant over geometries 
2: Unknown or uninitialised column: `geometry`.

Do you think it will work after increasing max_to_route above 250?