Utility trips checks validation - Githubissues

nptscot / npt

Data processing code, also use this repo for issue tracking for the Network Planning Tool. See https://nptscot.github.io for development version

https://www.npt.scot/

GNU Affero General Public License v3.0

5 stars 0 forks source link

Utility trips checks validation #470

Closed Robinlovelace closed 4 months ago

Robinlovelace commented 4 months ago

As shown here: https://github.com/nptscot/npt/blob/main/code/tests/test-utility-uptake.md

And here for proposed solution: https://github.com/nptscot/npt/blob/main/code/tests/od-gen.md

And here: https://github.com/nptscot/npt/blob/main/report-utility-methods.md

cc @hussein-mahfouz as discussed this morning, thoughts on any of this welcome.

Robinlovelace commented 4 months ago

This is the line where we calculate the number of shopping trips associated with each zone:

https://github.com/nptscot/npt/blob/80aa6aa02e4c6abc6769f981899003b19a8aa14d/R/utility_trips.R#L44

Robinlovelace commented 4 months ago

We should account for the fact that the n. trips depends on location e.g. rural/urban. Separate issue for now. Next step: break that total into distant bands.

Robinlovelace commented 4 months ago

Plan: after that line of code, assign trip numbers by distance band:

[ ] 0-1 km route distance (0-(1/1.3)km Euclidean)
[ ] 1-2 km
[ ] 2-5 km
[ ] 5-10 km
[ ] 10-15 km
[ ] 15-20 km route distance

Robinlovelace commented 4 months ago

One issue in previous version of code: the destinations of trips were constrained to a single point. It would make more sense to use the OS POIs as destination subpoints I think. Illustration of how this could look for Aberdeen: