nptscot / nptscot.github.io

Network Planning Tool for Scotland: front end.
https://www.npt.scot
GNU Affero General Public License v3.0
7 stars 5 forks source link

Update website with new data #134

Open Robinlovelace opened 5 months ago

Robinlovelace commented 5 months ago

@wangzhao0217 has completed a new full build, plan is to get it uploaded onto production by end of the month. Jobs are:

Robinlovelace commented 5 months ago

See new data for testing: https://github.com/nptscot/npt/releases/tag/v2024-01-17-23-50

We should think of automated ways to test these, e.g. a script to auto download/unzip the relevant files. Should that live in this repo or elsewhere? Thoughts very welcome @mvl22 .

wangzhao0217 commented 5 months ago

@Robinlovelace the simplified_network is there; I mistakenly checked the wrong folder...sorry.

Robinlovelace commented 5 months ago

Perfect, there are still some improvements we can make to the build process, but that means we have everything we need to test, I think. I'll check to json files to see if https://github.com/nptscot/npt/issues/369 is fixed.

@mvl22 could you try running it locally with this DataZone json file? json

joeytalbot commented 5 months ago

I've just had a look at routes_utility_fastest.Rds in the linked data, and they only cover the geo_subset area around the Forth Bridge.

Robinlovelace commented 5 months ago

I've just had a look at routes_utility_fastest.Rds in the linked data, and they only cover the geo_subset area around the Forth Bridge.

Thanks for the heads-up Joey, I did think it sounded like a fast build! I guess this needs to be set to false before the next build: https://github.com/nptscot/npt/blob/main/parameters.json#L6

joeytalbot commented 5 months ago

You should also specify a new routing date or delete the previous route files.

mvl22 commented 5 months ago

could you try running it locally with this DataZone json file? [json]

The website expect PMTiles, not JSON. When this has become PMTiles you can then test it by setting tileserverTempLocal: true and ensuring that source has a localUrl specifying the path.

https://github.com/nptscot/nptscot.github.io/blob/refactor/js/layer_control.js#L3

While I could add support for JSON rendering into the codebase, that will eat up time for what is temporary testing of a file rather than anything used in production. I imagine you'd prefer the limited time available used for system improvements...

Robinlovelace commented 5 months ago

PMTiles output is fine.

Robinlovelace commented 1 month ago

Done for the rnet datasets in #184. We need to update the zones and other datasets now I think.

Robinlovelace commented 2 weeks ago

Blocked on #212