search

nptscot / nptscot.github.io

Network Planning Tool for Scotland: front end.
https://www.npt.scot
GNU Affero General Public License v3.0
7 stars 5 forks source link

Update section title, close #196 #197

Closed Robinlovelace closed 4 months ago

Robinlovelace commented 4 months ago

Seems like a no brainer so merging now FYI @mvl22. Quickfire reviews appreciated.

mvl22 commented 4 months ago

See my comment above that you missed.

Robinlovelace commented 4 months ago

See my comment above that you missed.

Which comment? I think you need to submit the review before the comment is visible.

Note: I hit that issue, where I commented on a PR but it was invisible because I hadn't submitted the review, multiple times while I was getting started with reviewing PRs. May have missed something but there's no comment here as far as I can tell. Screenshot below:

image

Robinlovelace commented 4 months ago

A way to verify whether or not a comment is available to others: open the link in a private tab in which you're not linked in. Can you see it?

mvl22 commented 4 months ago

This is what I wrote and still see above - screenshot:

IMG_4003

Robinlovelace commented 4 months ago

OK, so yes, seems that the review is still Pending. Can you click on the Files changed button in the top right and complete the review?

mvl22 commented 4 months ago

OK, so yes, seems that the review is still Pending. Can you click on the Files changed button in the top right and complete the review?

What an awful UI - the mixture of asynchronous commenting, which gives the appearance of being committed, and a submit button ('Review') is most unclear...

Now done anyway.

I'll mop up this change in my coming changes today/tomorrow, to save another pull request.

Robinlovelace commented 4 months ago

:+1: