205 add road type field to most datasets to aid rendering 1

[Robinlovelace]

• First pass at updated colours for new infrastructure labels
• Update colourscheme
• Add highway type, close #205
• Use new cbd_layer
• Use simple cycle infrastructure value
• Attempt to get infrastructure layer working

[Robinlovelace]

Heads-up @mvl22 this is all working, except for the colours when selecting existing infra for some reason. Please review, make any necessary changes and merge.

[mvl22]

Heads-up @mvl22 this is all working, except for the colours when selecting existing infra for some reason.

Has the layer name in the data changed, from 'Cycle infrastructure' to 'Infrastructure type', as per the key you have redefined in f060461d98b72c17174410dca4bb00555f753c60 at line 230? The label can be changed independently if you have not changed the layer name.

[Robinlovelace]

Bingo!

Please review and merge when ready @mvl22

[mvl22]

Add infra type

Ah right, yes, if the layer name was changed that has to be matched in the drop-down.

(I intend in future to generate the drop-downs from the dataset definitions, so that there is then only a single source of these definitions. The refactoring hasn't quite got that far yet.)

[Robinlovelace]

Question for you Martin: where is the best place to explain that

Separated cycle track means infrastructure that is physically separated from the carriageway and not alongside a major road

?

A popup maybe?

Also see #193 where this may be best placed.

[Robinlovelace]

@mvl22 tagging in case you don't see this, I'm hitting the hay z z

[mvl22]

A popup maybe?

Add the definitions to the manual, section 'Cycling by Design compliance', between the clos start/finish markers in that file. That is what is then used in the (i) popup.