search

nptscot / nptscot.github.io

Network Planning Tool for Scotland: front end.
https://www.npt.scot
GNU Affero General Public License v3.0
8 stars 6 forks source link

Update coherent network #228

Open wangzhao0217 opened 3 months ago

wangzhao0217 commented 3 months ago

Hi @Robinlovelace and @mvl22,

The latest coherent network can be found here https://github.com/nptscot/outputdata/releases/download/v2024-07-02/combined_coherent_networks_2024-07-02.pmtiles

The updated coherent network has two attributes now: all_fastest_bicycle_go_dutch, and growth.

The client has requested the following changes:

  1. The network was previously color-coded based on the group attribute. It should now be colour-coded based on the all_fastest_bicycle_go_dutch attribute. The colour scheme and breaks can be the same as the base layer. image

  2. For the growth attribute, which includes values in the list (1, 2, 3, 4), we need to add a filter to allow slicing based on the growth value. This is growth = 1, Edingburgh image This is growth = 2, Edingburgh image

If anything is unclear, let's ask for clarification.

Robinlovelace commented 3 months ago

This is a clear and well-written issue, thank you Zhao. Good documentation + issue reports -> quick fixes is the hope, keep us posted Martin on thoughts. A benefit of the change in colourschemes: one less colourscheme for the user to think about and greater consistency across layers.

Robinlovelace commented 2 months ago

Nudge on this @mvl22 the geometry looks right but the colours are still outdated:

image

wangzhao0217 commented 1 month ago

@Robinlovelace @dabreegster Hi all, please find the latest coherent network here: https://github.com/nptscot/outputdata/releases/tag/v2024-08-01

dabreegster commented 1 month ago

Thanks. Do you have GeoJSON, GPKG, or another format, even just a sample for one area? pmtiles is meant for rendering only.

wangzhao0217 commented 1 month ago

Got it , just uploaded GeoJSON to the same release https://github.com/nptscot/outputdata/releases/tag/v2024-08-01 image

Robinlovelace commented 1 month ago

A 1 MB .geojson sounds like a good place to start: a LOT of data to process but if it can handle that (I think national) dataset it should be able to handle any of the regional datasets.

dabreegster commented 1 month ago

I'm mostly seeing MultiLineStrings. In combined_CN_1 in Edinburgh, one of them looks like this: image A simpler example has "spurs" off a main route: image

The route drawing functionality as it's built now handles LineStrings, not MultiLineStrings. 1) How do you imagine a user editing / selecting / splitting / deleting parts of the multi line strings? 2) Are these generated from line strings at road segment level and getting combined later? Could the input into scheme sketcher not be combined?

Robinlovelace commented 1 month ago

These are good questions @dabreegster. I agree, keeping the results as LineStrings will make thing simpler. Ultimately these are based on OS OpenRoads data (more consistent and simpler than OSM geometries), so +1 to being faithful to that data structure, which is provided as LineStrings, right?

Robinlovelace commented 1 month ago

There is value in grouping the linestrings. However, we do that by providing an attribute called 'group' and maybe other attributes, including 'Potential'.