search

nptscot / osmactive

Extract active travel infrastructure from OSM
https://nptscot.github.io/osmactive/
Other
7 stars 0 forks source link

`classify_cycle_infrastructure_portugal` function #5

Open Robinlovelace opened 3 months ago

Robinlovelace commented 3 months ago

3-way classification for Portugal:

As discussed with @temospena

temospena commented 3 months ago

The result for this re-classification should look somehow like this:

image

Robinlovelace commented 3 months ago

Great to have a target to aim for, shouldn't be too tricky..

temospena commented 2 months ago

A work in progress here: https://github.com/nptscot/osmactive/compare/portugal_classification

The code is not tidy enough to include in the osmactive.R Any help in here, @joeytalbot ?

This looks like this, which seems to have a correct classification.

image

There are some streets that have a wrong classification in the OSM, regarding the "foot" variable, and I can't find a reason why is that. Examples: https://www.openstreetmap.org/way/976381232 https://www.openstreetmap.org/way/686372908 https://www.openstreetmap.org/way/498545079

Robinlovelace commented 2 months ago

Looks good, let's get it merged is my thinking then we can progress on #30 for more testing..

temospena commented 2 months ago

Hi @matheusgomesms 👋 These are some examples of the cycleways I found with foot tag.

Matheus is an OSM editor, part of the OSM Portugal community, with with a lot of experience in cycling tags.

Robinlovelace commented 2 months ago

Fantastic, thanks for the work and link-ups Rosa!

matheusgomesms commented 2 months ago

Hi @temospena, as I said in our previous e-mail, and as you all are probably aware, the foot=* tag means that pedestrians can use that feature (in this case, a cycleway). The cycle tags in OSM were updated a couple of years ago, so probably this is the reason these cases were mapped like that.

Let me comment about each case:

1 - this is not "wrong", but given that it was mapped before the improvement cycle tags in OSM, it can now be mapped as:

bicycle=designated
foot=designated
highway=cycleway
segregated=yes

However, there is now already a footway right beside the cycleway, so another (and easier) alternative is to simply remove the foot=yes tag.

2 - Same case as before. But since the footway is not explicitly mapped, the foot=yes tag can be updated to foot=designated and added the bicycle=designated tag as well.

3 - Same as (2).

Not sure how this affects your code, but right now, this is how it is supposed to be tagged in OSM.

Please let me know if you have any other doubts!

Robinlovelace commented 2 months ago

Very useful comments, many thanks 👍