search

npx / vscode-hide-gitignored

19 stars 7 forks source link

Ignore patterns from global gitignore #9

Open matusf opened 4 years ago

matusf commented 4 years ago

Hi! First of all, thanks for this awesome extension! I've added a functionality to ignore patterns from global git ignore. I'm sorry if this is not the most idiomatic typescript, I was coding in typescript for the first time :smiley: However, I'm happy to follow your review recommendations if you have any.

closes #1

npx commented 4 years ago

Hello @matusf!

Thank you for your work! In order to incorportate your change more easily I updated the project a little bit and added code formatting.

I would appreciate it if you could rebase your changes onto my latest upstream changes.

As for the code, I will add some comments!

matusf commented 4 years ago

@npx rebased!

npx commented 4 years ago

@matusf can you see the comments I made a while ago?

matusf commented 4 years ago

No, I don't see any of them.

matusf commented 3 years ago

ping @npx

matusf commented 3 years ago

Yes, I see it now, thanks. I'll make the changes shortly.

matusf commented 3 years ago

Hi @npx, I've made the changes. Could you please check if it's all ok?

LuisPeregrina commented 2 years ago

@npx good enhancement. I would vote to include this.