search

nqkdev / home-assistant-vacuum-styj02ym

163 stars 134 forks source link

Add more attributes of vacuum #14

Open KrzysztofHajdamowicz opened 4 years ago

KrzysztofHajdamowicz commented 4 years ago

This PR contains improvements created by @kovbalazs89, @pierosavi and @bashau in forks of this repository and merges them into one piece, allowing upstream repository to be in sync with downstream ones.
To be merged after #13

raress96 commented 4 years ago

I have tested this after I also got the update of library from #15 and the changes from #13, and I can confirm that I have all the services in HA and at least from what I tested so far it seems to work ok on my model (viomi.vacuum.v8)

X1pheR commented 4 years ago

Hi @nqkdev , could you please look at this PR of @KrzysztofHajdamowicz ? I would really love to use this custom component with all the added functionality. Would also be great to have it added to HACS too.

nelsongraca commented 3 years ago

For those interested I forked the repo and merged this and the pep8 PRs

X1pheR commented 3 years ago

For those interested I forked the repo and merged this and the pep8 PRs

Great! In the meanwhile I'm using KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym since it was the most up to date and gives me extra functionality and the bug resolved. How is yours compared to this one?

KrzysztofHajdamowicz commented 3 years ago

For those interested I forked the repo and merged this and the pep8 PRs

Great! In the meanwhile I'm using KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym since it was the most up to date and gives me extra functionality and the bug resolved. How is yours compared to this one?

https://github.com/KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym/compare/master...nelsongraca:master They seem identical, where @nelsongraca has a little bit older dependencies.

X1pheR commented 3 years ago

For those interested I forked the repo and merged this and the pep8 PRs

Great! In the meanwhile I'm using KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym since it was the most up to date and gives me extra functionality and the bug resolved. How is yours compared to this one?

KrzysztofHajdamowicz/home-assistant-vacuum-styj02ym@master...nelsongraca:master They seem identical, where @nelsongraca has a little bit older dependencies.

Thanks for the clarification. Didn't know you could compare that simple :)

nelsongraca commented 3 years ago

@KrzysztofHajdamowicz missed that you had an updated repo, in that case mine is useless, BTW is this the same as the viomi.vacuum.v8? I got that model and some attributes seem wrong.

KrzysztofHajdamowicz commented 3 years ago

BTW is this the same as the viomi.vacuum.v8? I got that model and some attributes seem wrong.

Dunno :( I've just merged changes from existing forks of upstream repo, I own STYTJ02YM and it is hard for me to debug hardware I did not have in my hands :(

nelsongraca commented 3 years ago

Nevermind found the SKU: SKV4109GL not the same, time to try it out.