Closed aloisklink closed 1 year ago
Merging #530 (b26a67b) into main (a5bb42e) will increase coverage by
0.07%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #530 +/- ##
==========================================
+ Coverage 53.57% 53.64% +0.07%
==========================================
Files 144 144
Lines 20005 19993 -12
==========================================
+ Hits 10717 10725 +8
+ Misses 9288 9268 -20
Impacted Files | Coverage Δ | |
---|---|---|
src/runctl.c | 57.86% <100.00%> (+3.93%) |
:arrow_up: |
tests/test_edgesec.c | 97.87% <100.00%> (+0.01%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Skip
free()
-ing theeloop
parameter inrun_ctl()
. If this parameter is passed in torun_ctl()
, we should let the callerfree()
it instead of us.This also fixes a memory leak in
test_edgesec.c
.I've also simplified the
run_ctl()
cleanup code by merging the success andgoto run_engine_fail
code.The only two differences between the two was:
return 0
, while the failure bitreturn -1;
, which was easy to fix.goto run_engine_fail
branch, it was hidden behind anif (.. != NULL)
branch: https://github.com/nqminds/edgesec/blob/b722d492217a769f0e86904fb0ceac7f92212940/src/runctl.c#L608-L610