nqminds / edgesec

Secure router - reference implementation
https://edgesec.info
MIT License
6 stars 1 forks source link

Move `get_config_dhcpinfo()` function into `src/dhcp/dhcp_config_utils.c` #548

Closed aloisklink closed 1 year ago

aloisklink commented 1 year ago

In edgesec, we have two slightly different definitions of get_config_dhcpinfo(), in:

This PR proposes replacing these two definitions with a single definition in a new file called src/dhcp/dhcp_config_utils.c.

Minor differences:

codecov[bot] commented 1 year ago

Codecov Report

Merging #548 (803d702) into main (da4f33e) will decrease coverage by 0.03%. The diff coverage is 71.79%.

@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
- Coverage   54.14%   54.11%   -0.03%     
==========================================
  Files         144      145       +1     
  Lines       21043    20999      -44     
==========================================
- Hits        11394    11364      -30     
+ Misses       9649     9635      -14     
Impacted Files Coverage Δ
src/config.c 79.65% <ø> (+0.60%) :arrow_up:
tests/dhcp/test_dnsmasq.c 100.00% <ø> (+4.80%) :arrow_up:
src/dhcp/dhcp_config_utils.c 71.79% <71.79%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.