nqthqn / craconweb

https://www.cravecontrol.org
0 stars 1 forks source link

User messages "jitter" field #62

Closed daved closed 7 years ago

daved commented 7 years ago

Is the "jitter" field from User response and User add used in the frontend? From what I read, they are not, but I am unsure.

Also, there is a jitter field in the gcycle entity/decoder/encoder, but not in the related interface messages. This may be dead code. Which brings up the issue of removing as much dead code as possible if the PB->Elm generator is no longer in use.

daved commented 7 years ago

ping @nqthqn

nqthqn commented 7 years ago

I agree. Removing dead code == good.

It's easy in elm, just delete it and see if you can compile stuff ;)

I think jitter is posted in the fMRI game with the gsession

nqthqn commented 7 years ago

http://comments.gmane.org/gmane.comp.lang.elm.general/9634

nqthqn commented 7 years ago

for now we have --warn to show ununsed module imports and missing annotations.

daved commented 7 years ago

I think jitter is posted in the fMRI game with the gsession

Yes, it's necessary in that case. Is it helpful in gcycle?

daved commented 7 years ago
grep -rho "Entity\.\w*" * --exclude-dir=elm-stuff | sort | uniq
Entity.Game
Entity.gameDecoder
Entity.Group
Entity.groupDecoder
Entity.id
Entity.proto <- this is a byproduct of the code gen
Entity.Role
Entity.roleDecoder
Entity.Ugimage
Entity.ugimageDecoder
Entity.Ugimgset
Entity.ugimgsetDecoder
Entity.User
Entity.userDecoder
Entity.UserRecord
Entity.userRecordEncoder

All remaining types, encoders, and decoders will be removed from the file (with the exception of those used by the above types/functions).

daved commented 7 years ago

It was 1700+ lines removed. Once the open PRs are merged, I'll rebase and make a PR for this.