search

nrabinowitz / pjscrape

A web-scraping framework written in Javascript, using PhantomJS and jQuery
http://nrabinowitz.github.io/pjscrape/
MIT License
997 stars 159 forks source link

Phantomjs2.0 #63

Open tanhaoqin opened 9 years ago

tanhaoqin commented 9 years ago

PhantomJS phantom.args.length method call is outdated.

TypeError: undefined is not an object (evaluating 'phantom.args.length')

pjscrape.js:877 in global code

nrabinowitz commented 9 years ago

Will consider this PR when I package for npm - otherwise, there's no easy way to ensure the user has the right Phantom version, and I don't want to support both 2.x and 1.x if I can help it.

daniel-lucio commented 9 years ago

So, will your project run on PhanthomJS 2?

jpz commented 8 years ago

Broken here also.

daniel-lucio commented 8 years ago

I can confirm the patch works fine

jpz commented 8 years ago

Pull request 64 does run fine - thanks.

daniel-lucio commented 8 years ago

I am trying a little example using phanthom2 and it gets like a zombie. The debug does not give any useful information.

Phanthom2 examples (no pjscrape) works okay.

mihutz92 commented 7 years ago

Hi! So, current version of pjscrape works only with phantomJS 2 ?