nraboy / ng-cordova-oauth

AngularJS oauth library for use with Apache Cordova projects
https://www.thepolyglotdeveloper.com
MIT License
456 stars 199 forks source link

How to add a new provider ? #294

Closed bonninf closed 7 years ago

bonninf commented 7 years ago

I'm trying to add support for the Xee provider and for this I added the oauth.xee.js file and modified the oauth.js file as expected. However, using in my code, I get the error "$cordovaOauth.xee is not a function". What is normal because the see support is not added neither to ng-cordova-oauth.js nor to ng-cordova-oauth.min.js

What is the process to make that? Should I copy manually the code to ng-cordova-oauth.js?

Thanks for your help Francois

nraboy commented 7 years ago

After adding your changes to the source files you need to build it with grunt. Did that still not work?

bonninf commented 7 years ago

I did know about Grunt. I installed and launched it and all is well working.

Thanks Nic for your help and your very good job. François

Le 16 oct. 2016 à 16:49, Nic Raboy notifications@github.com a écrit :

After adding your changes to the source files you need to build it with grunt. Did that still not work?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nraboy/ng-cordova-oauth/issues/294#issuecomment-254051321, or mute the thread https://github.com/notifications/unsubscribe-auth/ABClsy2oTH0rDpv7tWfua7Hd7QYoIiT4ks5q0jmBgaJpZM4KX7Qz.

nraboy commented 7 years ago

Awesome! Submit a PR request when you're done :-)