search

nraboy / ng-cordova-oauth

AngularJS oauth library for use with Apache Cordova projects
https://www.thepolyglotdeveloper.com
MIT License
456 stars 199 forks source link

Yandex & Mail.ru services #301

Open mche opened 7 years ago

mche commented 7 years ago

Hi!

Push big russian Yandex and Mail.ru services.

nraboy commented 7 years ago

Just to confirm, since I am not familiar with this service. You've tested it and it works great with your PR?

Once you confirm it is working, I'll merge it.

Referencing https://github.com/nraboy/ng-cordova-oauth/pull/299

mche commented 7 years ago

Sorry for PR #299 there is incorrect response_type=code. Now works response_type=token.

Im recheck api and had tests works fine for this PR.

matheusrocha89 commented 7 years ago

Great job @mche I Like the code. 👍 If it's working and after some changes I think this PR can be merged. @mche Thanks for your contribution

nraboy commented 7 years ago

Thanks @matheusrocha89

mche commented 7 years ago

Ok, I had inspected the recomendations.

nraboy commented 7 years ago

We ready to merge?

mche commented 7 years ago

Does my comments in README.md are clean? Or may be remove them?

matheusrocha89 commented 7 years ago

The comments for me are fine. I think you can remove the comments on the code and let them there on readme

mche commented 7 years ago

@matheusrocha89 Im sorry but comments in code does needs like for me.