search

nraboy / ng-cordova-oauth

AngularJS oauth library for use with Apache Cordova projects
https://www.thepolyglotdeveloper.com
MIT License
456 stars 199 forks source link

*Updated linkedin endpoints for using new API version. #319

Closed briannovillo closed 7 years ago

briannovillo commented 7 years ago

Added headers: 'Access-Control-Allow-Origin': '' 'X-Requested-With': 'XMLHttpRequest'

Headers were added for avoid ionic CORS error "XMLHttpRequest cannot load linkedin.com/uas/oauth2/accessToken", mentioned in different sites, see:

https://github.com/nraboy/ng-cordova-oauth/issues/32 http://stackoverflow.com/questions/21630081/linkedin-button-xmlhttprequest-cannot-load http://stackoverflow.com/questions/23823510/xmlhttprequest-cannot-load-https-www-linkedin-com-origin-http-xx-xx-i http://stackoverflow.com/questions/23580772/client-server-no-access-control-allow-origin-when-returning-json-from-own-doma

briannovillo commented 7 years ago

Hi guys, I took the dare to update the Linkedin endpoints for show the new popup because has a best UI and because the security workflow is more complete, for example, when we use the login from an emulator, this send an email to the user with a code advising that is an unknown device.

I hope this change to be useful for the community.

Regards, Brian Novillo.

nraboy commented 7 years ago

Looks good, but contributions are not accepted on the master branch:

https://github.com/nraboy/ng-cordova-oauth#contribution-rules

Please make sure you use the already existing development branch which is typically ahead of the master branch.

Best,

briannovillo commented 7 years ago

Oops! You're right, sorry, I'm closing this pull request since I opened a new one for development branch https://github.com/nraboy/ng-cordova-oauth/pull/320.

Regards.