Open KyleMassacre opened 6 years ago
Sorry for the late reply.
Did you test it to see if it's working correctly?
Yes, I did test test it and it worked. One thing I noticed is that for a brief second some sort of 404 error pops up before the in app browser closes and I couldnt figure out what that was but after looking at other modules I didnt know what was different.
Did you happen to find an error by chance?
Since this is specific to Laravel Passport plugin I think it's better to rename to laravelPassport or something similar since passport is a very generic name. There is a middleware for express to make authentication called passport too, so another name will be more clear for developers that will use.
I went ahead and change it to laravelPassport and pushed it
Hi, @KyleMassacre. Thanks for your contribution. Just want to ask you about some points:
laravelPassport
or something similar sincepassport
is a very generic name. There is a middleware for express to make authentication calledpassport
too, so another name will be more clear for developers that will use.