search

nrako / react-component-resizable

A React component to implement cross-browser event based resize detection
MIT License
70 stars 16 forks source link

Update react version to support v15.x #20

Closed justinanastos closed 8 years ago

justinanastos commented 8 years ago

nrako/react-component-resizable#19

justinanastos commented 8 years ago

Easy peasy, merge me :)

zekedroid commented 8 years ago

Awesome 👍 And does it work fine with no warnings when on react 15?

justinanastos commented 8 years ago

Awesome 👍 And does it work fine with no warnings when on react 15?

Yes it does @zekedroid !

ahutchings commented 8 years ago

+1 We're upgrading to v15 as well and use this component heavily.

jayfunk commented 8 years ago

+1 as well.

nrako commented 8 years ago

Sorry for the delay, 1.0.0 🎉 is out.

BTW... what happened with npm 3? shrinkwrap is a complete mess in that version... :rage3: I had to go back to node LTS (I've been doing some Swift lately, I didn't follow much the node world lately)

ahutchings commented 8 years ago

NPM 3 tries to install dependencies into a "maximally flat" directory structure - https://docs.npmjs.com/how-npm-works/npm3. That probably changed where object-assign got installed in your tree.

In my opinion you'd be fine removing the shrinkwrap file from this component, since it's recommended for applications to shrinkwrap anyhow.

Thanks for merging!

nrako commented 8 years ago

😮 I see... thanks for the link @ahutchings, and you're right I'd probably be fine without the shrinkwrap file.