search

nrako / react-component-resizable

A React component to implement cross-browser event based resize detection
MIT License
70 stars 16 forks source link

Unexpected token #24

Closed arcanis closed 7 years ago

arcanis commented 8 years ago

The object spread syntax isn't currently standardized. Since the last update, this module requires extra care when using it, because it won't work out of the box with webpack and server-side react rendering (even on modern ES6-compatible Node versions).

I think this change should be reverted, or the main entry point should be updated to use the dist build instead of the actual sources, at least until object spread is officially implemented in v8.

nrako commented 8 years ago

You're right @arcanis thanks. This shouldn't require a transpiler to work. I'm just gonna change the package.json to quickly target the dist build.

arcanis commented 8 years ago

Unfortunately, just using the dist build is not enough (it causes some issues with Webpack, which warns because the output file is partially minified). I've fixed the issue in my branch, here, I can open a PR if you like it.

nrako commented 8 years ago

Yeah I saw that, it's because browserify didn't bundled it as a UMD.

Thanks for the PR proposition but I'd like to keep the transpiling in place, specially if I have to keep maintaining this code. It's a quick fix and I'll push something soon hopefully, but now I took a second first look on the tests and they aren't really great so now I'm trying to quickly fix them.

arcanis commented 8 years ago

Any news ? My PR is still there if you're willing to merge it :)

zekedroid commented 8 years ago

yup, waiting on this fix as well

sverrejoh commented 7 years ago

This is causing a lot of trouble. I wouldn't recommend expecting users to transform your source code manually.

react-virtualized comes with an AutoSizer component doing the same job, which solves this issue for me.

nrako commented 7 years ago

Hi, I'm apologizing for this stalling issue. I made a new release under 1.1.0-rc1 through this PR #28 which should fix this issue. Please let me know if it doesn't.

This #28 PR should hopefully make it simpler and more enjoyable to contribute to this, for me first but also anyone else.