search

nrandecker / particle

A simple portfolio Jekyll theme:
https://nrandecker.github.io/particle/
MIT License
1.03k stars 1.1k forks source link

Fix build and vulnerabilities #44

Closed fabienjuif closed 5 years ago

sconetto commented 5 years ago

I've tested your changes in my project and it seems to be working, now I can run gulp and the server starts to run, I will just take a deeper look why my main.css isn't updating along with the sass task.

And another minor (I don't know how it affects the system), I'm getting an error on js task:

[15:15:32] Starting 'js'...
[15:15:32] Plumber found unhandled error:
 GulpUglifyError: unable to minify JavaScript
Caused by: SyntaxError: Unexpected token: keyword (const)
File: $HOME/project/src/js/main.js
Line: 3
Col: 2
[15:15:32] Finished 'js' after 43 ms

any thoughts?

fabienjuif commented 5 years ago

Yeah, on my project I changed the const to var so it passed

fabienjuif commented 5 years ago

@sconetto I fixed the JS in this PR.

About the CSS, you should change the sass, not the css. I just tried to change the main color in _vars.scss and the application refreshed and print my new color (red). So I guess it works!

nrandecker commented 5 years ago

@fabienjuif Thanks for your work with the build issues. I haven't actively maintained this project in several months. Im testing your changes now will be adding them to the main repo shortly.

fabienjuif commented 5 years ago

@nrandecker You are welcome :) thank you for the merge ;)