search

nraynaud / webgcode

Online G-Code simulator, controller code for STM32F4-Discovery and google chrome extension to send the code to it.
http://nraynaud.github.io/webgcode/webapp/visucamTest.html#/
Other
373 stars 162 forks source link

G02 with only Y parameter locks up webgcode #13

Closed dafzor closed 7 years ago

dafzor commented 7 years ago

When writing the code G02 Y20 simulating it will lock webgcode tool in a permanent simulation cycle.

nraynaud commented 7 years ago

Thanks for your report, I confirm I can reproduce this behavior, let me have a closer look.

nraynaud commented 7 years ago

Upon further inspection, I don't think that code is legal, because there is no way to compute the arc path without either a center or a radius, I'll just detect and report the error.

nraynaud commented 7 years ago

Ok, I detected and reported the error. If you think I misunderstood either your bug report or how the G2 command is supposed to work, please re-open with your comments.

dafzor commented 7 years ago

The issue is indeed that inputing the code in that manner soft locks the webgcode app into a simulation loop instead of simply trowing an error, thus forcing a reload to continue using it.

I'm currently learning gcode and using your web app on my phone to validate my exercises gcode, thus the higher probability of bad code inputs.

Your fix is perfect, thanks

nraynaud commented 7 years ago

ok, it's fixed for this instance. But expect a lot more issues of the same type, I did almost no verification of the input.

dafzor commented 7 years ago

I'll report them as I find them if you don't mind.

nraynaud commented 7 years ago

Yes, thank you, that will increase the general quality.