First of all, thanks for the great work on this library. I wanted to mention a few issues I had while installing your library related to dependency versions. I'm submitting only one issue for several, altough not identical issues, all related to the versions in the pyproject.toml file. This is a broader take on #439
In general the dependencies of this library are more restrictive than core strawberry-graphql and strawberry-graphql-django. This means that currently, the project package of an end user needs to be adapted to strawberry-django-auth instead of relying on the same versions that its "parent" libraries. This is particularly true for the python version, for django. Additionally, and independently, the django-stubs are not compatible with V5.
[ ] Is it a bug?
[x] Is it a new feature?
[ ] Is it a question?
[x] Can you reproduce the problem?
[x] Are you running the latest version?
[x] Did you check for similar issues?
[ ] Did you perform a cursory search?
Description
I am using poetry as a package manager and the rest of this thread relies on it.
Looking at pyproject.toml in this library, the dependencies are stricter than its "parent" libraries. Also, the django-stubs are incompatible with V5.
And strawberry-django/pyproject.toml : the python version is less restrictive, and the django version is less restrictive (especially <5.1 is not present)
Finally, when having django-stubs = {extras = ["compatible-mypy"], version = "^5.0.2"}, strawberry-django-auth install fails.
I am wondering if there is a reason why those <3.13, <5.1 checks are implemented ? Also, would it be possible that the django stubs version is set to be more liberally, so that version 5.0.2 is also supported whitout breaking the lock tree ?
Steps to Reproduce
Here are two examples where the library install will fail.
Example A: for python
Setup a poetry project with a python version, for instance 3.12
I expected the installation to work when using regular dependency definiton.
Actual behavior
In example A : the installation fails unless python = ">=3.12,<3.13" or django-stubs are downgraded. I believe a similar error will occur when django 5.1 is released.
In example B : the installation fails unless a force-install is made.
Prerequisites
First of all, thanks for the great work on this library. I wanted to mention a few issues I had while installing your library related to dependency versions. I'm submitting only one issue for several, altough not identical issues, all related to the versions in the
pyproject.toml
file. This is a broader take on #439In general the dependencies of this library are more restrictive than core
strawberry-graphql
andstrawberry-graphql-django
. This means that currently, the project package of an end user needs to be adapted tostrawberry-django-auth
instead of relying on the same versions that its "parent" libraries. This is particularly true for the python version, for django. Additionally, and independently, the django-stubs are not compatible with V5.Description
I am using
poetry
as a package manager and the rest of this thread relies on it.Looking at pyproject.toml in this library, the dependencies are stricter than its "parent" libraries. Also, the django-stubs are incompatible with V5.
I compare this to the strawberry/pyproject.toml : the python version is less restrictive
And strawberry-django/pyproject.toml : the python version is less restrictive, and the django version is less restrictive (especially <5.1 is not present)
Finally, when having
django-stubs = {extras = ["compatible-mypy"], version = "^5.0.2"}
,strawberry-django-auth
install fails.I am wondering if there is a reason why those
<3.13
,<5.1
checks are implemented ? Also, would it be possible that the django stubs version is set to be more liberally, so that version 5.0.2 is also supported whitout breaking the lock tree ?Steps to Reproduce
Here are two examples where the library install will fail.
Example A: for python
strawberry-django-auth
Example B : For django-stubs
django-stubs[compatible-mypy]
latest (v5.0.2)strawberry-django-auth
, will failI expected the installation to work when using regular dependency definiton.
Actual behavior
In example A : the installation fails unless
python = ">=3.12,<3.13"
ordjango-stubs
are downgraded. I believe a similar error will occur when django 5.1 is released.In example B : the installation fails unless a force-install is made.
Requirements
from my pyproject.toml
I have put the outputs of poetry show in a gist, to avoid bloating this thread.