search

nrc / find-work

find something Rusty to work on
Apache License 2.0
20 stars 21 forks source link

Implemented "negative_labels" to filter out claimed issues #36

Open budziq opened 7 years ago

budziq commented 7 years ago

Already configured for cookbook and bindgen.

fixes https://github.com/nrc/find-work/issues/15

budziq commented 7 years ago

@fitzgen I've pushed commit providing a test for the negative_label filtering.

I can't really say that I love how the test was written and how mock_struct_data had to be reorganized (or butchered) for the feature to be testable. It seams that the filtering might have a manageable/testable form if it were part of the github client.

Should I rewrite?

nrc commented 7 years ago

re testing, could you factor out the filtering from the fetch function and test just the filtering with a unit test, rather than testing the whole fetch?

budziq commented 7 years ago

@nrc thanks for the review! I'll update the PR later this week.