search

nrc / graphql

A Rust GraphQL server framework
Apache License 2.0
236 stars 12 forks source link

Suppress Warnings #26

Closed scrogson closed 6 years ago

scrogson commented 6 years ago

This PR fixes #21.

I'm not quite sure if adding the #[allow(dead_code)] for the K* structs is the correct way to handle that or not.

I'm not sure why rust is complaining about those. Maybe a bug?

scrogson commented 6 years ago

@nrc I changed #[allow(dead_code)] to #[allow(unused)]. I'm not sure which one is preferred.

nrc commented 6 years ago

Thanks for the PR. I think for the unused attributes we should either remove the code or live with the warnings (I think for some of them my intention was that these would be used soon as we extend the parsers, but aren't needed yet). The easiest thing for now is probably to land the import changes, and circle back to the rest in a few weeks when we have a better idea about the parsers.

scrogson commented 6 years ago

Ok...sounds good.