nrc / rust-dxr

Rust indexing in DXR
8 stars 0 forks source link

Fix callgraph functionality #11

Open nrc opened 9 years ago

nrc commented 9 years ago

Find callers and find callees search sort of work, but we should make them work properly - accounting for dynamic/static calls etc. (I'm not exactly sure what is wrong right now, but I don't get the results I expect sometimes).

nrc commented 9 years ago

E.g., https://dxr.allizom.org/rust/search?q=%2Bcallers%3A%22%3CPrivacyVisitor%3C%27a%2C+%27tcx%3E%3E%3A%3Aensure_public%22 misses the calls in https://dxr.allizom.org/rust/search?q=%2Bfunction-ref%3A%22%3CPrivacyVisitor%3C%27a%2C+%27tcx%3E%3E%3A%3Aensure_public%22, even though it's an inherent method.

nrc commented 9 years ago

Note that, at least within a crate, my callgraph demo does this properly.