search

nrdg / cloudknot

A python library to run your existing code on AWS Batch
https://nrdg.github.io/cloudknot/
Other
70 stars 17 forks source link

GitHub actions #208

Closed arokem closed 3 years ago

arokem commented 4 years ago

Secrets are not passed to pull requests created from forks. Checking if we can use the AWS credentials from a PR created directly from here instead.

arokem commented 4 years ago

Hey @richford : do you understand the test failures on https://github.com/nrdg/cloudknot/pull/208/checks?check_run_id=707986269 ? I don't get these running locally on my machine (but it's probably picking up my default AWS profile)

richford commented 3 years ago

@arokem. What is the status of this PR after merging #220. My understanding is the the tests workflow in this PR will need to be rewritten to look more like the one currently on master. And then it'll further add the publish to pyPI workflow.

arokem commented 3 years ago

I think that I should close this one and restart this effort on a new branch.