Automatically specify 'resource_type = SPOT' if bid_percentage is set

nrdg / cloudknot

A python library to run your existing code on AWS Batch

https://nrdg.github.io/cloudknot/

Other

70 stars 17 forks source link

Automatically specify 'resource_type = SPOT' if bid_percentage is set #214

Closed richford closed 3 years ago

richford commented 4 years ago

Resolves #140

arokem commented 4 years ago

Maybe we can get rid of the resource_type key-word argument altogether? Is there any use-case where that's handy?

richford commented 4 years ago

Good point. Potential solution: if bid_percentage is None (which is the default), then we set resource_type = "EC2". If it is provided as a parameter, then we set resource_type = "SPOT". Sound good?

richford commented 3 years ago

Rebased on master

richford commented 3 years ago

Rebased after merging of #220. Ready for review.

arokem commented 3 years ago

🎉