Make resource tagging more consistent

nrdg / cloudknot

A python library to run your existing code on AWS Batch

https://nrdg.github.io/cloudknot/

Other

70 stars 17 forks source link

Make resource tagging more consistent #215

Closed richford closed 3 years ago

richford commented 4 years ago

Resolves #146.

It seems that one cannot assign tags to IAM policies. So that is left of the list from #146. But this PR adds consistent tagging to

EC2 resources launched in the Batch compute environment
ECR repos
S3 buckets

arokem commented 4 years ago

LGTM. Should we merge #213 as it is now, before rebasing/merging this and #214? At least we'll get some unit testing out of that...

richford commented 4 years ago

I definitely want to wait until we get the unit testing figured out before merging this and #214 (because if my previous track record is any indication, these two PR will break something). I'm trying to figure out the remaining error on #213 right now and will comment on that PR when I've manage to gain some clarity.

richford commented 3 years ago

Rebased on master.

richford commented 3 years ago

Rebased and fixed. Ready for review @arokem (along with #214, #217, #218)

arokem commented 3 years ago

Awesome.