nrdg / cloudknot

A python library to run your existing code on AWS Batch
https://nrdg.github.io/cloudknot/
Other
71 stars 17 forks source link

WIP: Fix zenodo metadata #241

Closed arokem closed 4 years ago

richford commented 4 years ago

Did it all come down to that?

arokem commented 4 years ago

I don't think so. The error you saw was:

{
    "status": 400, 
    "message": "Validation error.", 
    "errors": [
        {
            "field": "metadata.creators.0.type", 
            "message": "Unknown field name."
        }, 
        {
            "field": "metadata.creators.1.type", 
            "message": "Unknown field name."
        }
    ]
} 

Which suggests that maybe something is wrong here: https://github.com/nrdg/cloudknot/blob/master/.zenodo.json#L6 and https://github.com/nrdg/cloudknot/blob/master/.zenodo.json#L14, but I believe that this conforms with the zenodo specification: https://developers.zenodo.org/#representation (search for the "contributors" field). So, I am not sure. It's also hard to check without depositing. One thing we could do is email the Zenodo help desk. They helped me figure this out on pyAFQ: https://github.com/yeatmanlab/pyAFQ/commit/c3f8dbfc5a192fcc722ad774188c014c9f5ea17d

richford commented 4 years ago

Made one more correction, removing the type field from my name since it seems it's not valid for creators. I'm going to go ahead and merge after the checks pass.