search

nrdg / cloudknot

A python library to run your existing code on AWS Batch
https://nrdg.github.io/cloudknot/
Other
71 stars 17 forks source link

FIX: Require object names to conform to AWS URI regex #260

Closed richford closed 3 years ago

richford commented 3 years ago

Resolves #256 Resolves #258

This PR requires object names to conform to the AWS URI regex. Previously, underscores were silently converted to dashes and then checked for regex compliance, which caused user confusion. Now, we simply throw an error when the name doesn't comply and simply a more helpful error message.

I also fixed the regex so that it must match on the entire name string instead of just the beginning.

Lastly, I fixed a bug in which DockerImage was adding .py onto it's name which generated from an existing script.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling d17a7229c1e4946b942d50b285c4d7b775a5e60c on richford:fix/underscores into e48b6ab5fcd705fa7c95363066fa746f6ddbe2fd on nrdg:master.