search

nrdg / cloudknot

A python library to run your existing code on AWS Batch
https://nrdg.github.io/cloudknot/
Other
70 stars 17 forks source link

Windows carriage return #268

Closed arokem closed 3 years ago

arokem commented 3 years ago

Also documents issues with pywin32.

richford commented 3 years ago

Thanks @arokem. That's a nice tidy fix! Looks like there's just a linting error. Can you run black and commit/push?

arokem commented 3 years ago

I think that the test errors have to do with the moto mocking. The reason I think that's the case is because I can run the code with no error outside of the moto mocking context.

@richford : is there a particular reason that you pinned a particular dev version of moto here?

richford commented 3 years ago

I pinned it to that version to capture one of my PRs to moto, which resolved this issue. But we can pin to any version greater than that if needed.

arokem commented 3 years ago

Sadly, upgrading moto to the most recent version doesn't help anyway.

arokem commented 3 years ago

Looks like we're hitting this, but the suggested fix -- upgrading to a recent version of moto -- is not helping.

arokem commented 3 years ago

Even worse, this upgrade seems to cause some additional new failures.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling f792169daf7cd89f5469c7aa72b18bec40163e27 on arokem:windows_carriage_return into ae225dcc00175ce25d468c03bd46ee85436362cb on nrdg:master.

arokem commented 3 years ago

OK - pinning responses to 0.12.0 and keeping the pin on moto seems like the magic combination for now, at least until that issue on moto is resolved. It would be great to merge this, if this is indeed ready, and put out a new release, as I expect some new users in early January.

arokem commented 3 years ago

Oh - BTW: I have verified that the fix for \r does work as intended with at least on Windows user, who had that issue.