search

nre-learning / antidote-selfmedicate

Configs and scripts for spinning up a local instance of Antidote on your laptop for testing and lesson development
Apache License 2.0
11 stars 19 forks source link

Provide vagrantfile option #34

Closed smk4664 closed 5 years ago

smk4664 commented 5 years ago

Added a vagrantfile and a copy of the selfmedicate script that runs minikube without a VM. The copy was created to allow continued use of the existing selfmedicate script.

Mierdin commented 5 years ago

Awesome! I'll take a look at this shortly.

smk4664 commented 5 years ago

I found a problem with this, I am correcting now and will add another commit. The line endings got messed up when copied over the files.

smk4664 commented 5 years ago

Evidently that is just a problem with my local copy, it looks like it is using the unix line endings on github.

Mierdin commented 5 years ago

Ah, for some reason I forgot you have to install Vagrant plugins manually. So looks like this is the new procedure:

vagrant plugin install vagrant-hostsupdater
vagrant up

Does that look right? I'm testing it again right now but I'm guessing that's what I did wrong.

Also, this brings up the topic of an addition to the docs that covers this. Ideally it would be a separate page, just like these are separate scripts. And in the future when we make this the primary way of doing things, we'd delete the old doc too. Is this something you are interested in taking on? I may have some time to do this in the next week or two but didn't want to do it if you were planning on adding the doc yourself. Up to you.

smk4664 commented 5 years ago

Yes, that looks great. In Windows, the escalation wasn't being handled, so I followed their article for adding it once then it being set automatically every time.

Yes, I need to find the docs and fork the repository. I will work on that this week. Antidote halt && Antidote up the second time don't work as expected, so I also be trying to fix that.

Mierdin commented 5 years ago

Awesome. For the docs change, https://antidoteproject.readthedocs.io/en/latest/contribute/docs.html should be helpful.

Sounds like you want to make some additional changes to this PR so I'll hold off on merging for now. Just give me a heads up when you feel it's good to go. Thanks again!

smk4664 commented 5 years ago

This is ready now.