search

nre-learning / antidote-selfmedicate

Configs and scripts for spinning up a local instance of Antidote on your laptop for testing and lesson development
Apache License 2.0
11 stars 19 forks source link

Add a message about the missing hostsupdater plugin in Vagrantfile #45

Closed olberger closed 4 years ago

olberger commented 5 years ago

One should not run vagrant up if the hostsupdater plugin isn't there... however this may not be a blocker.

In such case, maybe a warning message could be useful, for instance at the end of the provisionning down in the Vagrantfile, with something like:

  if not defined?(VagrantPlugins::HostsUpdater)
    config.vm.provision "shell", privileged: false, inline: <<-EOF
      echo "You should install the Vagrant::Hostsupdater plugin to support configuration of the 'antidote-local' hostname."
    EOF
  end
smk4664 commented 5 years ago

That's a great idea. HostsUpdater is not required, but very helpful.

olberger commented 5 years ago

Well... it seems it's rather necessary (or the user needs to apply the change manually): see https://github.com/nre-learning/antidote-selfmedicate/issues/39#issuecomment-539682914

Mierdin commented 4 years ago

I'm going to close this - hostsupdater is a requirement but I don't think it's necessary to add a blocking check. It's in the docs, so if someone doesn't want to follow the docs, they're on their own.