search

nre-learning / antidote-selfmedicate

Configs and scripts for spinning up a local instance of Antidote on your laptop for testing and lesson development
Apache License 2.0
12 stars 19 forks source link

Remove requirement for a specific hostname #64

Closed Mierdin closed 4 years ago

Mierdin commented 5 years ago

This removes the requirement for a specific hostname in the ingress definitions, and then also removes the logic to work with the /etc/hosts file, because it's not needed anymore.

Closes https://github.com/nre-learning/antidote-selfmedicate/issues/52

Mierdin commented 5 years ago

@smk4664 You're right. Updated to retrieve eth1 dyamically (and left a note on that portion of the Vagrantfile to let future us know it's being relied upon) in https://github.com/nre-learning/antidote-selfmedicate/pull/64/commits/537652309b1e3638314b178f6c1db236d3059c18

smk4664 commented 5 years ago

@Mierdin Eth1 should work, but should we default it to localhost, then pass in the IP from the vagrantfile using antidote_config['vm_config']['private_network_ip']? This way, the script could still work standalone? I am also curious if Eth1 works if we change vm images.

Mierdin commented 4 years ago

I'm deciding to close this in favor of what I did in https://github.com/nre-learning/antidote-selfmedicate/pull/69/

I removed the hostname rules from the ingresses, but I still think there's value in having a hostname to point stuff to, particularly in the case of webssh which would otherwise need some sort of YAML templating nonsense to configure properly.