nre-learning / antidote-selfmedicate

Configs and scripts for spinning up a local instance of Antidote on your laptop for testing and lesson development
Apache License 2.0
11 stars 19 forks source link

Please document antibridge #75

Closed olberger closed 4 years ago

olberger commented 4 years ago

Would you be able to document antibridge ?

Its repo seemed to be forked off CNI... but that ain't really documented AFAICS

https://github.com/nre-learning/antidote-selfmedicate/blob/f02ddf4fd2e3315967421c54ecb059b68069baa2/selfmedicate.sh#L111

Also, would it be contributable to the original project (not maintaining a forked version, etc.) ?

Thanks in advance.

Mierdin commented 4 years ago

As discussed, this is really no different than the bridge plugin, other than setting a single flag to permit LLDP. We never got where we wanted to with the rest of LLDP support, so this is pointless. Rather than documenting this, I'd like to remove it. I'll open an issue in antidote-core to remove references to this and once antidote-core supports the regular bridge plugin again we can remove this from selfmedicate.