search

nre-learning / proposals

A repository for collaborating on in-process governance and technical documents
1 stars 1 forks source link

(MP1) Proposed Design for Antidote Core v1.0 #3

Closed Mierdin closed 4 years ago

Mierdin commented 5 years ago

This PR contains the current proposed design of Antidote's "core services" as a prerequisite for a platform v1.0 release.

This is just the first of several "mini-projects" designed to bring the Antidote platform to a v1.0 state.

For the most readable copy of this design, please view the Github-rendered version on my branch by clicking here.

To leave comments or questions, however, please use the "Files Changed" tab above to provide inline comments by clicking the blue plus sign to the left of a changed line (please do this, when leaving comments, context is important, and it will make it much easier to understand and incorporate feedback).

Mierdin commented 4 years ago

I noticed that the UUID is a combination of the LessionId and the SessionId. Is there any consideration in changing this to match a standard, such as Version 4 UUID? Or even Version 3 or 5 to keep the Namespaces?

@smk4664 Apologies for the long delay in response.

This is a good idea, and in the new data model we'll actually be generating the UUID server-side, so we can definitely force conformance to one of those formats. We'll have to make sure we can deterministically (and while avoiding collisions) come up with a suitable format for the K8s namespace names (since I believe there are length limitations there) but that shouldn't be hard.

Mierdin commented 4 years ago

Note that https://github.com/nre-learning/antidote-core/pull/141 was merged today and implements a large portion of what's discussed above.

Not everything outlined above was implemented in this PR, and in addition, not everything that was implemented was done in the exact manner described above. See https://github.com/nre-learning/antidote-core/pull/141 for information on the decisions made during implementation.

Since there have been no additional comments to the above in quite a while, I'll be merging this PR as well. Anyone who wishes to provide additional comments/questions is still welcome to do so, either in the form of an issue here, or via our community forums.