search

nreco / data

Fast DB-independent DAL for .NET Core: abstract queries, SQL commands builder, schema-less data access, POCO mapping (micro-ORM).
https://www.nrecosite.com/dalc_net.aspx
MIT License
183 stars 39 forks source link

Implement RecordSetReader.GetSchemaTable for compatibility with netcore3 GetColumnSchema() impl #53

Closed VitaliyMF closed 4 years ago

VitaliyMF commented 4 years ago

Implementation of CanGetColumnSchema GetColumnSchema (DbDataReaderExtensions) was changed: https://github.com/dotnet/runtime/commit/c10cc1ede0789554d672a3558bd3618299f9b9b3

In particular, now CanGetColumnSchema always returns true (previously it was true only if DbDataReader implements IDbColumnSchemaGenerator). As a result, now check CanGetColumnSchema becomes useless -> it is expected that DbDataReader always implement GetSchemaTable.

To fix this RecordSetReader.GetSchemaTable should be implemented.

VitaliyMF commented 4 years ago

Shipped in 1.1