nreco / data

Fast DB-independent DAL for .NET Core: abstract queries, SQL commands builder, schema-less data access, POCO mapping (micro-ORM).
https://www.nrecosite.com/dalc_net.aspx
MIT License
183 stars 39 forks source link

DbDataAdapter.Select().ExecuteReader ignores ApplyOffset option #63

Closed VitaliyMF closed 4 years ago

VitaliyMF commented 4 years ago

If database doesn't support offset/limit in SQL NReco.Data handles this on its side (skips first N rows for offset, and reads only rows according to the limit specified in the Query).

However, when DbDataReader.ApplyOffset = true ExecuteReader() ignores Query.RecordOffset / Query.RecordCount properties which is not consistent with other methods like ToList() ToDictionaryList() etc.

VitaliyMF commented 4 years ago

Shipped in 1.2.2