nrenner / brouter-web

Web client for BRouter, a routing engine based on OpenStreetMap
https://brouter.de/brouter-web/
MIT License
371 stars 73 forks source link

Historic objects and wind visuals #105

Open randmized opened 6 years ago

randmized commented 6 years ago

Hi Norbert, i really like your tool and use it almost weekly to plan our rides. On the sunday ride, wind blowing into my face i realized, i did not check the wind data. So planning process: very often find myself "cycling" between multiple tabs like windfinder and historic places to create my route. My idea was to add two additinal layers the the bike router. The key "historic" from OSM is exsiting and i can query it using overpass weather data could be obtained from openweathermap. Unfortunate i am not a GIS person nor dit i read into your project deep enough to understand how to implement layers but i thought ill drop you a message anyhow.

Let me know what you think, i would be happy to contribute

nrenner commented 6 years ago

i really like your tool and use it almost weekly to plan our rides.

Nice to hear, this also goes to @abrensch for the backend routing engine and brouter.de hosting.

The key "historic" from OSM is exsiting and i can query it using overpass

There once also was a request to add youth hostels. I think it would make sense to add a general way to select and query POIs (points of interest) from Overpass API.

I created a separate issue for that: POI layer #106

weather data could be obtained from openweathermap.

Not sure what you have in mind exactly, as far as I can see, there are two different types of weather data for wind direction visualizations.

The wind animation on Windfinder is based on the GFS forecast grid model. There are several libs (e.g. windable) using GFS for such a particle animation.

But that data would need to be downloaded, converted and cached. I don't know about @abrensch, but I currently don't see us doing that on his server.

OpenWeatherMap on the other hand, allows to query data for specific stations or locations, e.g. with leaflet-openweathermap. Wind direction and speed values could be shown as wind barbs.

Unfortunate i am not a GIS person nor dit i read into your project deep enough to understand how to implement layers

No need to be a GIS expert, brouter-web is based on the Leaflet map library, which is meant to be simple to use. As a very basic example see the code snippet on the home page and the Quick Start Guide on how to add a tile layer (pre-rendered images provided by a tile server). In brouter-web this is done in Map.js.

The use cases here are a bit more involved, with connecting to external APIs and adding markers for wind barbs or for selected POIs. Ideally such additions would come in the form of an external Leaflet plugin that is easy to integrate.

A couple of plugins, libraries and open source apps seem to exist for these use cases, which already have done all the hard work.

Let me know what you think, i would be happy to contribute

While I would find adding POI and wind layers useful, I consider them rather as nice to have. And with a long queue of requests for core features, I probably won't be able to implement them myself in the near future.

But I would be happy to help if you or somebody else are having a go at it.