search

nrepl / piggieback

nREPL support for ClojureScript REPLs
480 stars 48 forks source link

It is possible to just eval in CLJS and not create a new REPL for each evaluation #79

Closed bhauman closed 6 years ago

bhauman commented 6 years ago

This code details how its possible to just have an eval and not have to do a full cljs-repl boot for each evaluation.

The functions highlighted below only need to be evaluated with cljs.env/compliler bound.

https://github.com/bhauman/rebel-readline/blob/master/rebel-readline-cljs/src/rebel_readline/cljs/service/local.clj#L57-L79

This will speed up the evaluation significantly and as a bonus simplify things so that we can evaluate all the sent forms and provide interrupt to get the prompt back.

This is a very straightforward fix. @cemerick ^

bbatsov commented 6 years ago

The link you've posted seems to be broken.

bhauman commented 6 years ago

I fixed the link.

cemerick commented 6 years ago

Hi Bruce!

I'm sorry for the radio silence. I know you've been eager to get this (finally) folded in.

I need to just admit that I'm not likely to return to this, nevermind continuing proper maintenance and such. So, I want to get out of your way.

Can I give you commit, and then you can do whatever you think is right? Presumably we can also get you appropriate privs on clojars.

You can catch me on irc most of the time, where we can work out any details, etc.

bhauman commented 6 years ago

Sounds great. :)

On Mar 12, 2018, at 6:47 AM, Chas Emerick notifications@github.com wrote:

Hi Bruce!

I'm sorry for the radio silence. I know you've been eager to get this (finally) folded in.

I need to just admit that I'm not likely to return to this, nevermind continuing proper maintenance and such. So, I want to get out of your way.

Can I give you commit, and then you can do whatever you think is right? Presumably we can also get you appropriate privs on clojars.

You can catch me on irc most of the time, where we can work out any details, etc.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.