search

nrepl / piggieback

nREPL support for ClojureScript REPLs
480 stars 48 forks source link

make eval just eval rather than creating a new repl for each one #80

Closed bhauman closed 6 years ago

bhauman commented 6 years ago

fixes #79

bhauman commented 6 years ago

OK now I'm looking at the tests. It's really impressive that all the tests fail given that the code works fine.

bhauman commented 6 years ago

If you run lein test you will see that all tests are passing on nashorn.

Travis seems to be having a fundamental build problem.

There is one test failing for rhino and that is the printing test. I'm not sure what is going on there.

bhauman commented 6 years ago

well the printing test does not work for rhino. But, when I use Rhino at the REPL printing works just fine so I'm going to chalk that up to a difficult testing environment.

bhauman commented 6 years ago

I'm going to call this finished except for fixing the test somehow.

bbatsov commented 6 years ago

@bhauman Do you plan to cut a new release for this change soon? I think that'd be pretty cool.

bbatsov commented 6 years ago

well the printing test does not work for rhino. But, when I use Rhino at the REPL printing works just fine so I'm going to chalk that up to a difficult testing environment.

I wonder if anyone wants a rhino REPL at all - maybe we can just drop the ugly code around it and point people in the direction of nashorn.