bbatsov
commented
6 years ago @gonewest818 Can you rebase your PR on master? For some reason I didn't see it and I did a few conflicting changes in the mean time.
Closed gonewest818 closed 6 years ago
bbatsov
commented
6 years ago @gonewest818 Can you rebase your PR on master? For some reason I didn't see it and I did a few conflicting changes in the mean time.
gonewest818
commented
6 years ago Yes, I’ll take a look at that. Sorry I’ve gone dark for a few weeks… other obligations have gotten in the way.
On Apr 16, 2018, at 11:51 AM, Bozhidar Batsov notifications@github.com wrote:
@gonewest818 https://github.com/gonewest818 Can you rebase your PR on master? For some reason I didn't see it and I did a few conflicting changes in the mean time.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clojure-emacs/piggieback/pull/83#issuecomment-381710183, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWM9q28HE2GLgOx8xkAPr5QMlVxPxLpks5tpOgpgaJpZM4S5Or5.
bbatsov
commented
6 years ago No worries!
Btw, I just decided to revert my own commits, as I noticed you did pretty much the same things and you beat me to it. ;-)
bbatsov
commented
6 years ago (2) project.clj. Because I'm testing on multiple Clojure releases I don't want/need to declare clojure and clojurescript as :dependencies, they need to be specified in profiles. But I'm not sure I've got that set up correctly.
lein repl stopped working without a profile, so I guess you know the answer to that now. ;-)
This PR adds:
and removes:
Two specific things I'm requesting additional eyes on: (1) this macro which is really nothing more than a dummy to tell Eastwood I don't care about the return values in the body. Is there a more elegant way to deal with this? (2)
project.clj. Because I'm testing on multiple Clojure releases I don't want/need to declare clojure and clojurescript as:dependencies, they need to be specified in profiles. But I'm not sure I've got that set up correctly.