Bump Clojurescript for JDK 9 compatibility

nrepl / piggieback

nREPL support for ClojureScript REPLs

480 stars 48 forks source link

Bump Clojurescript for JDK 9 compatibility #84

Closed tirkarthi closed 5 years ago

tirkarthi commented 6 years ago

This PR bumps the Clojurescript version for JDK 9 compatibility. It also fixes the travis config to use lein instead of lein2.

Fixes : #77

Build failure related to repl output : https://travis-ci.org/tirkarthi/piggieback/jobs/359727935

bhauman commented 6 years ago

So this is a bit premature, as users who choose Java 9 will also need to choose to use CLJS 1.10.

We don't want to force it on them yet.

tirkarthi commented 6 years ago

Sorry, I might be wrong but is this the case where the clojurescript version in the project overrides piggieback so people need to use 1.10? Also any idea about the test case failure?

Shall I close the PR?

Thanks

bbatsov commented 6 years ago

The test failures are fixed on master.