search

nrepl / piggieback

nREPL support for ClojureScript REPLs
480 stars 48 forks source link

Drop support for rhino and all the junk related to it #86

Closed bbatsov closed 6 years ago

bbatsov commented 6 years ago

As we no longer support JDK 7, and rhino complicates the code of Piggieback a lot, it seems reasonable to me just to drop rhino, as nashorn (introduced in JDK 8) is the way to go.

bbatsov commented 6 years ago

I'd love to hear some feedback regarding this idea - any thoughts @bhauman @thheller?

thheller commented 6 years ago

I think all the engines now use the same unified REPL API so it probably doesn't make much sense to keep something rhino specific. shadow-cljs doesn't support it either for that matter.

bbatsov commented 6 years ago

Rhino is out, as is piggieback 0.3.