cichli commented 5 years ago

The printing test was failing on CLJS versions since 1.10 – I believe the cause is this commit. It seems REPL environments don't necessarily guarantee that printed output will end up in *out* (it's treated as a JS host concern), so I think the right thing to do is remove the test.

We can re-enable Eastwood once we remove the clojure.tools.nrepl compatibility requires.

Fixes #82.

codecov-io commented 5 years ago

Codecov Report

Merging #99 into master will increase coverage by 0.9%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master      #99     +/-   ##
=========================================
+ Coverage   83.58%   84.49%   +0.9%     
=========================================
  Files           2        1      -1     
  Lines         195      187      -8     
  Branches        9        9             
=========================================
- Hits          163      158      -5     
+ Misses         23       20      -3     
  Partials        9        9

Impacted Files	Coverage Δ
src/cider/piggieback.clj	`84.49% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06fcf78...f6cafa4. Read the comment docs.

bbatsov commented 5 years ago

Btw, it’s fine to remove the tools.nrepl compatibility at this point. I planned to do it, but I didn’t get to doing it. We just have to bump the version to 0.4 when this is done.

cichli commented 5 years ago

I have done on the branch which adds 0.6 compatibility (will PR once I merge this). It will still support 0.5 by sniffing for nrepl.middleware.interruptible-eval/default-executor though.

bbatsov commented 5 years ago

👍

nrepl / piggieback

CI updates + fixes #99

Codecov Report