search

nrf-rs / microbit

A Rust crate for BBC micro:bit development
BSD Zero Clause License
276 stars 61 forks source link

Unify names #112

Closed tsadowski closed 1 year ago

tsadowski commented 1 year ago

Hi, I have added common type aliases and structs for the GPIO pins on the edge connector. I did the same for ADC and SAADC with a common default initialization for 10 bit resolution. It is now possible to use the same code for v1 and v2 if the extra capabilities of v2 are not needed. There is also a new analog example using the common interface and a TIMER, GPIOTE and PPI servo example.

Cheers, Torsten

therealprof commented 1 year ago

Sorry for the branch update. I changed the CI to GH MQ and needed to trigger a new build.

This update looks great to me, thanks for that!

The only thing I'm not super crazy about is the addition of a lot of commented out pin assignments in the examples. Is there any specific reason why those might be desirable?

tsadowski commented 1 year ago

Hi Daniel,

do you mean the "pub struct Pins" in board.rs? I did not want to remove the (historic) struct that had in any case many pins commented out but I don't know why there are still pins that have no on board function and are not externally accessible.

Best Regards, Torsten

Am Donnerstag, dem 22.06.2023 um 07:17 +0000 schrieb Daniel Egger:

Sorry for the branch update. I changed the CI to GH MQ and needed to trigger a new build. This update looks great to me, thanks for that! The only thing I'm not super crazy about is the addition of a lot of commented out pin assignments in the examples. Is there any specific reason why those might be desirable? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>