search

nrf-rs / microbit

A Rust crate for BBC micro:bit development
BSD Zero Clause License
276 stars 61 forks source link

made sda and scl public for i2c interfaces #151

Closed BartMassey closed 3 months ago

BartMassey commented 4 months ago

Made the sda and scl pins in the various I2c Pins struct public.

Closes #150

qwandor commented 4 months ago

Please add this to the changelog.

BartMassey commented 4 months ago

Done. Also fixed a screwup. Apologies.

Will fix the MSRV break in a moment.

BartMassey commented 4 months ago

Nope. Fix did not work. Help figuring this out appreciated. MSRV workflow exits with status 101, no obvious log message I could see.

BartMassey commented 4 months ago

Looks like the version of fixed used by nrf51-hal requires Rust 1.78.0 even on feature embedded-hal-02. Bummer.

Shall we update the MSRV of this, or shall I try to get a fix in upstream?

qwandor commented 4 months ago

Weird, what changed to break that? Personally I don't mind updating the MSRV, but I'd like to understand what caused it to break.

BartMassey commented 4 months ago

Looks like the version of fixed used in nrf-hal got bumped from 1.0.0 to 1.25.1 on 2024-03-06 when nrf-hal was being prepared for 0.18 release. The new fixed has an MSRV.