nrf-rs / microbit

A Rust crate for BBC micro:bit development
BSD Zero Clause License
276 stars 61 forks source link

Bump version to 0.11.0 #64

Closed robyoung closed 3 years ago

robyoung commented 3 years ago

See: CHANGELOG.md

Added

Changed

robyoung commented 3 years ago

The MSRV check is failing because fixed v1.10.0 now requires Rust 1.53 or later.

I'm bumping the MSRV to 1.53 as fixed is a dependency of nrf-hal and therefore pretty key.

robyoung commented 3 years ago

I don't have permissions to publish to crates.io but I can do the tagging.

therealprof commented 3 years ago

Whoops... my bad. Try again now?

robyoung commented 3 years ago

Try publishing? Do I need to wait for this to be merged?

bors[bot] commented 3 years ago

Timed out.

therealprof commented 3 years ago

Try publishing?

Yes.

Do I need to wait for this to be merged?

Ideally yes in case something is wrong with the PR and requires a change. Re-publishing an already published version is not possible and would require a version bump...

therealprof commented 3 years ago

bors r+

therealprof commented 3 years ago

@robyoung I know why this is timing out: https://github.com/nrf-rs/microbit/blob/main/.github/bors.toml is still waiting for the previous MSRV to build successfully... Maybe we should change that step to be called MSRV instead a fixed version so we don't have to remember changing it again in multiple places in the future.

bors[bot] commented 3 years ago

Timed out.

robyoung commented 3 years ago

I've changed it manually for now. I need to have a play around to see if I can change the step title as the version number comes from the matrix value.

bors[bot] commented 3 years ago

Build succeeded:

robyoung commented 3 years ago

All done, I think.

therealprof commented 3 years ago

Seems the latest tags are not in order... did you put the v in front of the versions?

robyoung commented 3 years ago

Are we talking about git tag on this repo? If so, I think so. https://github.com/nrf-rs/microbit/releases/tag/v0.11.0

therealprof commented 3 years ago

Hm... https://github.com/nrf-rs/microbit/releases/tag/v0.10.1...v0.11.0

therealprof commented 3 years ago

I fixed it in situ. The comparison links were wrong except for the first and the last. 😅