nrf-rs / microbit

A Rust crate for BBC micro:bit development
BSD Zero Clause License
276 stars 61 forks source link

add microphone_pins and saadc to board #79

Closed elwerene closed 3 years ago

robyoung commented 3 years ago

Hi @elwerene thanks for the contribution, this looks like it could be really great. Could you add an example of how it would be used please? I've not done anything with the microphone before and I'm struggling to find an example.

Also, could you add an entry to the CHANGELOG.md please?

robyoung commented 3 years ago

Oh man! That is such a fun example, thanks!

Could you set the edition to 2018 on the example please? So that we don't have to bump the MSRV. I've run the CI locally and I think it should all pass after that.

robyoung commented 3 years ago

bors r+

bors[bot] commented 3 years ago

Build succeeded: