Closed mattheww closed 3 years ago
Tested it on a micro:bit v2 and it works (Scrolling once "Hello, world!") but a bit fast i think.
It looks great, thanks!
I'm a little torn about what to do with the MSRV. We have previously talked about it being informational only so we shouldn't hesitate to bump it (although I can't find that discussion now). However, it feels odd to bump the MSRV just because an example needs it. I can think of a couple of routes forward:
What do you think? I think my preference is for option 2.
@therealprof do you have an opinion?
I think the only MSRV problem is that I used edition 2021 for microbit-text
.
But it doesn't gain anything from that, so I might as well change it to 2018 and keep the MSRV in sync with microbit
's.
Hah, nice. Well that would neatly sidestep the issue.
bors r+
Build succeeded:
The implementation is in a separate
microbit-text
crate as discussed in #78.I've tested on micro:bit v1 only.
I did the example using RTIC, but I can just as easily do it without (or both ways).
Does this look sensible? If everyone's happy with
microbit-text
as it stands I can make it v1.0.0.